On Fri, 27 Aug 2010 09:50:49 -0500
Kent Yoder <[email protected]> wrote:
> > +
> > +#define testcase_error(_fmt, ...) \
> > + printf("* TESTCASE %s ERROR (%s:%d)) " _fmt "\n", \
> > + __func__, __FILE__, __LINE__, \
> > + ## __VA_ARGS__)
> > +
> > +#define testcase_error_f(_func, _fmt, ...) \
> > + printf("* TESTCASE %s ERROR (%s:%d)) " _fmt "\n", \
> > + _func, __FILE__, __LINE__, \
> > + ## __VA_ARGS__)
> > +
> >
> > #endif
>
> Looks good, Klaus. My only nit would be to send the output for the error
> cases above to stderr.
>
> Acked-by: Kent Yoder <[email protected]>
>
> Kent
I knew you'd raise this point ;-)
My reasoning is that, for a testcase, the "results" are the testcases
pass/fail results themselves. And stdout is usually used for 'results'.
So was wanting to use stdout only for BEGIN, SKIP, PASS and FAIL
messages. If we need additional debugging (hex dumps, warning or
informational messages etc), we would send them through stderr.
But changing that is simple ;-) What do you think?
-Klaus
--
Klaus Heinrich Kiwi | [email protected] | http://blog.klauskiwi.com
Open Source Security blog : http://www.ratliff.net/blog
IBM Linux Technology Center : http://www.ibm.com/linux/ltc
------------------------------------------------------------------------------
Sell apps to millions through the Intel(R) Atom(Tm) Developer Program
Be part of this innovative community and reach millions of netbook users
worldwide. Take advantage of special opportunities to increase revenue and
speed time-to-market. Join now, and jumpstart your future.
http://p.sf.net/sfu/intel-atom-d2d
_______________________________________________
Opencryptoki-tech mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opencryptoki-tech
