On Sun, 2 Jan 2011 20:49:32 +0900 Norikatsu Shigemura <[email protected]> wrote:
> Hi Klaus. > > pkcsconf always crashes on exit, so I researched by gdb. I > noticed that not finalized PKCS#11 API. I made a patch to fix > this issue by adding 'cleanup();'. Norikatsu, the patch isn't applying (there were some recent changes to the pkcsconf.c file that you might have missed), but I think you're change is still relevant. However, you might want to change the 'cleanup()' code to avoid calling "exit()" directly since we should now return a "valid" code from the main function. Could you please check that and re-send? Don't forget to include the "Signed-off-by:" line. Also, could you exemplify what kind of "crashes" you're experiencing with pkcsconf? I don't see any when running on Linux. Thanks, -Klaus > - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - > - > diff -urN opencryptoki-2.3.2.orig/usr/sbin/pkcsconf/pkcsconf.c > opencryptoki-2.3.2/usr/sbin/pkcsconf/pkcsconf.c > --- opencryptoki-2.3.2.orig/usr/sbin/pkcsconf/pkcsconf.c 2010-07-29 > 21:28:41.000000000 +0900 > +++ opencryptoki-2.3.2/usr/sbin/pkcsconf/pkcsconf.c 2011-01-02 > 20:39:51.706673751 +0900 > @@ -654,6 +654,8 @@ main() > free (newpin2); > } > > + cleanup(); > + > return rc; > > } > - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - > - > > Thank you. > -- Klaus Heinrich Kiwi | [email protected] | http://blog.klauskiwi.com Open Source Security blog : http://www.ratliff.net/blog IBM Linux Technology Center : http://www.ibm.com/linux/ltc ------------------------------------------------------------------------------ Learn how Oracle Real Application Clusters (RAC) One Node allows customers to consolidate database storage, standardize their database environment, and, should the need arise, upgrade to a full multi-node Oracle RAC database without downtime or disruption http://p.sf.net/sfu/oracle-sfdevnl _______________________________________________ Opencryptoki-tech mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opencryptoki-tech
