Il giorno gio, 20/01/2011 alle 11.00 -0200, Klaus Heinrich Kiwi ha
scritto:
> 
> hmm, I'm not sure. Couldn't we declare everything we don't want to be
> used externally as static? More work but also cleaner and more
> maintainable? 

That's gong to solve only part of the issue; what this patch does is
hiding symbols that cannot be marked static because are used from
different translation units than those that are defined in.

The "more work but better results" alternative would be to use ELF
symbol visibility for hiding everything and then only export the library
and plugin interfaces that are really required, which would also drop
the requirement for -Wl,-Bsymbolic (as that is required to avoid calling
into another object's symbol with the same name).

But to implement that it's a lot of work indeed, and at least I'd
suggest adding something like this for a start. This would cut down the
time required to load opencryptoki providers as well as stop my symbol
collision script to cry when checking a system where this software is
installed.

Main problem is I can't make heads and tails of the code as is, and I'm
not sure whether this regex covers all the required symbols.

-- 
Diego Elio Pettenò — Flameeyes
http://blog.flameeyes.eu/

Attachment: signature.asc
Description: This is a digitally signed message part

------------------------------------------------------------------------------
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand 
malware threats, the impact they can have on your business, and how you 
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Opencryptoki-tech mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opencryptoki-tech

Reply via email to