Hi, I recently turned on '-Wall' without the 'Wpointer-sign' flag for compiling Opencryptoki and saw hundreds of warnings that include implicit function declarations, unused variables, printf format errors, uninitialized variables, pointer sign issues etc. I used the following gcc version to compile the upstream version of library on a P7 LPAR. #gcc --version gcc (GCC) 4.8.3 20140911 (Red Hat 4.8.3-9)
The patch-set to follow fixes warnings in the following directories:- patch01_add_Wall_flag - Added -Wall option to configure.in script patch02_include_missing_prototypes - Added missing prototypes to /usr/include/pkcs11/ headers. patch03_api - Fixed print format issues, removed unused variable, provided forward declaration in usr/lib/pkcs11/api directory patch04_cca_stdll - Fixed missing header, missing braces in array, removed unused variables, print format issues in usr/lib/pkcs11/cca_stdll directory. patch05_common - Fixed print format issues, removed unused variables, added forward declarations to header files, fixed object_free return type in /usr/lib/pkcs11/common directory. patch06_soft_stdll - Fixed braces within the array element in usr/lib/pkcs11/soft_stdll/soft_specific.c. patch07_pkcscca - Initialize pointer variable, removed unused variables, added parentheses around binary operations in usr/sbin/pkcscca/pkcscca.c patch08_pkcsconf - Fixed print format issues, removed unused variables in usr/sbin/pkcsconf/pkcsconf.c patch09_pkcsslotd - Added missing headers, added extern function declarations, added forward function declarations in usr/sbin/pkcsslotd directory. Thanks, -- Vineetha Pai Linux Security Development, LTC notes - [email protected] Phone - 203 401 8099 ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ Opencryptoki-tech mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opencryptoki-tech
