Jakub, My apologies for the delay. Your changes coincided with changes we were making to fix compiler warnings. Your patches have been merged. Thanks!
regards, Joy On Mon, 2015-05-11 at 15:02 +0200, Jakub Jelen wrote: > On 05/04/2015 04:55 PM, Jakub Jelen wrote: > > Hi all, > > I went through recent problems in opencryptoki on Fedora and found out > > that there was quite enough undefined symbols that prevented to > > dynamically load particular modules or even start pkcsconf. More info > > can be found in this bugzilla [1]. We were using version 3.2 but > > patches are rebased for upstream version and directly applicable. > > > > First of all I turned on more strict checking in compiler to see these > > problems using "-Wl,--no-undefined". This revealed few missing files > > in SOURCES, header files, one library and requirement to moving one > > function from one file to another (I didn't find any reason to have it > > in the previous one). [patch 0001] > > > > Second issue appeared with change in our infrastructure. We started > > using gcc5 and there is different handling of inline function. Fix is > > backward compatible (at least it worked for me on older versions). > > [patch 0002] > > > > Additionally I found another typo in TRACE_EBUG, which was discovered > > because of more strict checking in compiler and which prevented > > application to build so I'm attaching this also. [patch 0003] > > > > If it doesn't work for you or you have any doubts, feel free to comment > > > > Best regards. > > Jakub Jelen > > > > [1] https://bugzilla.redhat.com/show_bug.cgi?id=1193560 > Sorry for one more email. After a build for s390, I found that we need > to count with _some_ undefined symbols for some proprietary library for > CCA tokens so we can't turn on more strict compile options. I went again > through the build logs on this arch and tried to extract the most of the > problems I found and rebased into more commits: > > * Patch [0001] is adding missing sw_crypt and mech_ec files during > compile time to prevent undefined symbols > * Patch [0002] is moving function get_ecsiglen from ecc_specific to > mech_ec, since this is the only place where is it used. > * Patch [0003] is adding missing header files for used symbols/functions > * Patch [0004] is reorganizing variables from header files to > * Patch [0005] is adding missing lber library at compile time (split > patch from last email) > * Patches [0006], [0007] are the same like described previous email > > Feel free to comment if you have any questions or concerns. > > ------------------------------------------------------------------------------ > One dashboard for servers and applications across Physical-Virtual-Cloud > Widest out-of-the-box monitoring support with 50+ applications > Performance metrics, stats and reports that give you Actionable Insights > Deep dive visibility with transaction tracing using APM Insight. > http://ad.doubleclick.net/ddm/clk/290420510;117567292;y > _______________________________________________ Opencryptoki-tech mailing > list [email protected] > https://lists.sourceforge.net/lists/listinfo/opencryptoki-tech ------------------------------------------------------------------------------ Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ _______________________________________________ Opencryptoki-tech mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opencryptoki-tech
