Dominik 'Rathann' Mierzejewski wrote: > On Friday, 23 January 2009 at 07:24, David Thompson wrote: >> Marco, >> >> Unfortunately I'm the only one that is doing any code review at this >> time. I have not had a chance to look at these but I will try to over >> the next couple of weeks. > > Good to see a living developer around here. :) > > Could you look at my patches as well? > > https://lists.berlios.de/pipermail/opendx2-dev/2007-August/000015.html > http://cvs.fedoraproject.org/viewvc/devel/dx/dx-open.patch?view=log > (unsafe open() usage) > > http://cvs.fedoraproject.org/viewvc/devel/dx/dx-gcc43.patch?view=log > (fix build with gcc>=4.3 similar to Marco's)
I think this last patch is in much better shape than mine. David, please, drop https://lists.berlios.de/pipermail/opendx2-dev/2008-June/000020.html from the list of patches to be reviewed (but, if you find time to look at them, please keep https://lists.berlios.de/pipermail/opendx2-dev/2008-June/000021.html ). > > Also, could you look at this old bug report? > https://lists.berlios.de/pipermail/opendx2-dev/2006-November/000012.html > I have no idea if this is a bug in LessTif or OpenDX. I've no idea about this. > And this one: > https://bugzilla.redhat.com/show_bug.cgi?id=469664 > http://www.opendx.org/bugs/view.php?id=236 For this one, reading the redhat bugzilla I've been redirected to http://www.opendx.org/cgi-bin/forum/YaBB.pl?num=1176042404 I can confirm that the simple patch reported at the forum thread end seems to fix this long standing issue, at least for me. Thanks GNE! Marco _______________________________________________ OpenDX2-dev mailing list OpenDX2-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/opendx2-dev
