Hi Dave... This note is for Dave but sure Jacek can read and reply :P, I have attached a new patch - http://jira.codehaus.org/browse/OPENEJB-172 - with the missing file and I renamed the *BasicStatelessTestLocalClient.java* to * BasicStatelessLocalTestClient.java* because it has a better meaning. Dave plz assign to me OPENEJB-148, OPENEJB-173 and OPENEJB-174, I will start working on them.
Thanks - Mohammad On 9/23/06, Mohammad Nour El-Din <[EMAIL PROTECTED]> wrote:
On 9/22/06, David Blevins <[EMAIL PROTECTED]> wrote: > > On Sep 22, 2006, at 12:59 AM, Jacek Laskowski wrote: > > > On 9/22/06, Mohammad Nour El-Din < [EMAIL PROTECTED]> wrote: > >> Hi Dave... > > > > Although it was specifically directed towards Dave I hope he won't > > mind if I respond instead...partially ;-) > > Even better! > > >> A patch has been attached to OPENEJB-172 - > >> http://jira.codehaus.org/browse/OPENEJB-172 -, this patch > >> solves the problems of the patch that has been attached to > >> OPENEJB-147 - > >> http://jira.codehaus.org/browse/OPENEJB-147 -, a comment is > >> added to OPENEJB-147 which points to this new patch and warns the > >> other > >> contributors from using any of the patches attached to OPENEJB-147. > >> > >> Please assign to me OPENEJB-148, OPENEJB-173 and OPENEJB-174, I > >> know they > >> are more than 2 :) but I want to make both the Stateless and > >> Stateful iTests > >> at the same level of implementation. > > > > I gave a shot to this patch and it doesn't work. A class is missing in > > the patch and it in turn breaks the build. Did I miss something? > > > > Compiling 168 source files to c:\oss\openejb3\openejb-itests\target > > \classes > > [INFO] > > ---------------------------------------------------------------------- > > -- > > [ERROR] BUILD FAILURE > > [INFO] > > ---------------------------------------------------------------------- > > -- > > [INFO] Compilation failure > > > > c:\oss\openejb3\openejb-itests\src\main\java\org\openejb\test > > \stateful\StatefulPojoLocalJndiTests.java:[11,48] > > cannot find symbol > > symbol: class BasicStatefulLocalTestClient > > public class StatefulPojoLocalJndiTests extends > > BasicStatefulLocalTestClient { > > > > Just as an FYI the stateless equivalent of this class subclasses from > "BasicStatelessTestLocalClient". Just for the sake of a uniform test > suite, BasicStatefulLocalTestClient should be renamed to > BasicStatefulTestLocalClient. Sure the names should be the same, I will name them BasicStatefulLocalTestClient and BasicStatelessLocalTestClient -David > > > >
