Please do not review the patch yet. i did not svn update before creating the patch, will do it tonight and submit the correct patch. Apologize for the confusion
On 1/16/07, Karan Malhi <[EMAIL PROTECTED]> wrote:
I have attached another patch, without the ANT libraries. Please review it. It works fine, I am not happy with the size of the jar it creates though. Any thoughts or input would be a good learning experience for me. https://issues.apache.org/jira/browse/OPENEJB-434 On 1/16/07, Jacek Laskowski < [EMAIL PROTECTED]> wrote: > > On 1/16/07, Karan Malhi < [EMAIL PROTECTED]> wrote: > > > I then tried to use the Jar class from ANT and it works perfectly > (same as > > the jar command) and is much simpler to use. Do you think we could use > the > > ant classes for openejb project.? > > I think Ant's fine as long as we don't use it as if we're executed it > from the command line, but using its classes. I'm not convinced, > though, it's the best bet as Ant is more than copying jars and for > such a small task we should not need it at all. > > Jacek > > -- > Jacek Laskowski > http://www.JacekLaskowski.pl <http://www.jaceklaskowski.pl/> > -- Karan Malhi
-- Karan Malhi
