On 2/15/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
Author: jwhitlock
Date: Thu Feb 15 10:23:10 2007
New Revision: 508064

URL: http://svn.apache.org/viewvc?view=rev&rev=508064
Log:
Patch by Sachin Patel for OPENEJB-514.  Separates all Eclipse ui portions of 
the plugin into it's own plugin.  Also adds activators for each plugin.
...
-Bundle-SymbolicName: org.apache.openejb.eclipse.wtp.server;singleton:=true
+Bundle-SymbolicName: org.apache.openejb.st.core;singleton:=true

What does the singleton property do?

--- 
incubator/openejb/trunk/openejb-eclipse/plugins/org.apache.openejb.st.core/plugin.xml
 (original)
+++ 
incubator/openejb/trunk/openejb-eclipse/plugins/org.apache.openejb.st.core/plugin.xml
 Thu Feb 15 10:23:10 2007
@@ -1,78 +1,58 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<?eclipse version="3.2"?>
-<plugin>
-   <extension
-         point="org.eclipse.wst.server.core.runtimeTypes">
-      <runtimeType
...
+<?xml version="1.0" encoding="UTF-8"?>
+<?eclipse version="3.2"?>
+<plugin>
+   <extension
+         point="org.eclipse.wst.server.core.runtimeTypes">
+      <runtimeType

Am I correct that the only change with the above file was about
formatting? Please correct svn settings of yours so there will not be
changes like the one above. It's hard to spot the actual change if
there were one.

Added: 
incubator/openejb/trunk/openejb-eclipse/plugins/org.apache.openejb.st.core/src/org/apache/openejb/st/core/Activator.java
URL: 
http://svn.apache.org/viewvc/incubator/openejb/trunk/openejb-eclipse/plugins/org.apache.openejb.st.core/src/org/apache/openejb/st/core/Activator.java?view=auto&rev=508064
==============================================================================
--- 
incubator/openejb/trunk/openejb-eclipse/plugins/org.apache.openejb.st.core/src/org/apache/openejb/st/core/Activator.java
 (added)
+++ 
incubator/openejb/trunk/openejb-eclipse/plugins/org.apache.openejb.st.core/src/org/apache/openejb/st/core/Activator.java
...
+       /*
+        * (non-Javadoc)
+        * @see 
org.eclipse.core.runtime.Plugins#start(org.osgi.framework.BundleContext)
+        */

Can we agree that such comments won't be included in the source code?
It's easy to avoid setting up the project in Eclipse (you can set it
up per project and per workspace).


--- 
incubator/openejb/trunk/openejb-eclipse/plugins/org.apache.openejb.st.ui/META-INF/MANIFEST.MF
 (added)
+++ 
incubator/openejb/trunk/openejb-eclipse/plugins/org.apache.openejb.st.ui/META-INF/MANIFEST.MF
 Thu Feb 15 10:23:10 2007
@@ -0,0 +1,14 @@
+Manifest-Version: 1.0
+Bundle-ManifestVersion: 2
+Bundle-Name: OpenEjb Server Tools UI Plug-in

OpenEjb != OpenEJB - EJB is all uppercase.

+Eclipse-LazyStart: true

What does it do?

--- 
incubator/openejb/trunk/openejb-eclipse/plugins/org.apache.openejb.st.ui/src/org/apache/openejb/st/ui/Activator.java
 (added)
+++ 
incubator/openejb/trunk/openejb-eclipse/plugins/org.apache.openejb.st.ui/src/org/apache/openejb/st/ui/Activator.java
 Thu Feb 15 10:23:10 2007
...
+       /*
+        * (non-Javadoc)
+        * @see 
org.eclipse.ui.plugin.AbstractUIPlugin#start(org.osgi.framework.BundleContext)
+        */

Again, no such comments, please.

Jacek

--
Jacek Laskowski
http://www.JacekLaskowski.pl

Reply via email to