On Mar 15, 2007, at 7:35 AM, Mohammad Nour El-Din wrote:
Hi David...
AFAIU , Do u mean that we should not annotate any fields or methods
in our
unit test cases ???
No, I'd say go ahead and check it in annotations and all. If there's
anything that breaks compliance or binds the itests to OpenEJB we
can fix it later, no big deal.
And for committing new code, how the review is going to
be ???
You're a committer now, so feel free to commit! :) Most of us will
likely read the commit log.
-David
On 3/14/07, David Blevins <[EMAIL PROTECTED]> wrote:
You've got commit now, Mohammad, so I say you should just go ahead
and commit these goodies.
Just a note about the itests since I haven't really looked too
closely at the patch, there's a hard rule against anything that would
break standards compliance or bind the itests to any OpenEJB-specific
internals. We might be toeing the line using annotations in test
cases, but we should be fine.
-David
On Mar 11, 2007, at 1:28 PM, Mohammad Nour El-Din wrote:
> Hi Jacek...
>
> Thanks for taking this burden :D. It is not committed yet. It
will my
> pleasure to have your feedback.
>
>
>
> On 3/11/07, Jacek Laskowski <[EMAIL PROTECTED]> wrote:
>
>> On 3/8/07, David Blevins <[EMAIL PROTECTED]> wrote:
>>
>> > Or really, Mohammad you're a committer now. Maybe you just
want to
>> > give an overview of what you added and how it works?
>>
>> I hope it's already got committed. If not, I could take a look
at it.
>> Let me know, Mohammad, if it's still relevant.
>>
>> Jacek
>>
>> --
>> Jacek Laskowski
>> http://www.JacekLaskowski.pl
>>
>
>
>
> --
> Thanks
> - Mohammad Nour
--
Thanks
- Mohammad Nour
