On 04/04/2011 04:43 AM, Richard Purdie wrote: [snip] > As an example of the opposite problem, sending 20 patches which change > DEPENDS = "gettext" to "inherit gettext" isn't especially useful and we > could do that as one patch.
I'd like to use this specific example (and some lessons learned doing this in openembedded.master) as a way to say "commits are cheap, and 20 commits for 20 recipes for 20 1-liners isn't a bad thing". If we do this as one commit and there's a subtle bug somewhere, the bisect says "this big list here". And you can probably find it. But if you do this as 20 commits, you know where it is. And if it's harder to fix (some of them were) you can just revert for now and not loose all of the work you did. Now, separate pull request? Certainly, and then you can just pull and check since to me that's a lot easier for the one-liners. -- Tom Rini Mentor Graphics Corporation _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core