Op 28 jun 2011, om 10:13 heeft Zhai, Edwin het volgende geschreven:
>
>
> Koen Kooi wrote:
>>
>> Op 28 jun 2011, om 09:42 heeft edwin.z...@intel.com het volgende geschreven:
>>
>> > From: Zhai Edwin <edwin.z...@intel.com>
>> >
>> > [YOCTO #1037] got fixed
>> >
>> > Signed-off-by: Zhai Edwin <edwin.z...@intel.com>
>> > ---
>> > meta/recipes-sato/webkit/webkit-gtk_svn.bb | 3 +++
>> > 1 files changed, 3 insertions(+), 0 deletions(-)
>> >
>> > diff --git a/meta/recipes-sato/webkit/webkit-gtk_svn.bb
>> > b/meta/recipes-sato/webkit/webkit-gtk_svn.bb
>> > index 6d134ad..c9ded4e 100644
>> > --- a/meta/recipes-sato/webkit/webkit-gtk_svn.bb
>> > +++ b/meta/recipes-sato/webkit/webkit-gtk_svn.bb
>> > @@ -10,6 +10,9 @@ LIC_FILES_CHKSUM =
>> > "file://WebCore/rendering/RenderApplet.h;endline=22;md5=fb969
>> > DEPENDS = "enchant gnome-keyring libsoup-2.4 curl icu libxml2 cairo
>> > libxslt libxt libidn gnutls gtk+ gstreamer gst-plugins-base flex-native
>> > gperf-native perl-native-runtime sqlite3"
>>
>> > DEPENDS_darwin8 = "curl icu libxml2 cairo libxslt libidn gnutls gtk+
>> > gstreamer flex-native gperf-native perl-native-runtime sqlite3"
>>
>> >
>> > +# To access ssl web pages
>> > +RRECOMMENDS_${PN} += "glib-networking"
>>
>> Since webkit uses soup and curl, wouldn't it be better to add the
>> RRECOMMENDS to soup instead? Webkit knows nothing about GIO.
>>
>
> I have considered it. But the drawback is that many other recipes depend on
> libsoup, so glib-networking will be built unnecessarily(webkit-gtk is not in
> core-image-sato). glib-netwoking just provides some plug-in style modules, so
> I think RRECOMMENDS from webkit-gtk should be okay( not RDEPENDS).
>
> In future, other recipes besides webkit-gtk may ask for glib-networking,
> maybe we can change it that time?
> What's your opinion?
I'd either put it in the lib that uses it (soup) or the app that needs it
(web-webkit), something in between is just confusing.
regards,
Koen
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
