On Tue, 2011-06-28 at 10:07 +0100, Phil Blundell wrote: > On Tue, 2011-06-28 at 08:51 +0800, Xu, Dongxiao wrote: > > > -----Original Message----- > > > From: openembedded-core-boun...@lists.openembedded.org > > > [mailto:openembedded-core-boun...@lists.openembedded.org] On Behalf Of > > > Phil Blundell > > > Sent: Monday, June 27, 2011 4:58 PM > > > To: Patches and discussions about the oe-core layer > > > Subject: Re: [OE-core] [PATCH 1/1] libc-locale: split locale handling > > > from libc > > > recipe. > > > > > > On Mon, 2011-06-27 at 16:37 +0800, Dongxiao Xu wrote: > > > > -PACKAGES = "${PN}-dbg ${PN} catchsegv${PKGSUFFIX} sln${PKGSUFFIX} > > > nscd${PKGSUFFIX} ldd${PKGSUFFIX} localedef${PKGSUFFIX} libcidn ${PN}-utils > > > ${PN}-pic ${PN}-dev eglibc-doc eglibc-locale libmemusage > > > libsegfault${PKGSUFFIX} eglibc-extra-nss eglibc-thread-db${PKGSUFFIX} > > > eglibc-pcprofile libsotruss${PKGSUFFIX}" > > > > - > > > > -PACKAGES_DYNAMIC = " \ > > > > - glibc-gconv-*${PKGSUFFIX} glibc-charmap-* > > > > glibc-localedata-* > > > glibc-binary-localedata-* \ > > > > - eglibc-gconv-* eglibc-charmap-* eglibc-localedata-* > > > eglibc-binary-localedata-* \ > > > > - locale-base-*${PKGSUFFIX}" > > > > +PACKAGES = "${PN}-dbg ${PN} catchsegv${PKGSUFFIX} sln${PKGSUFFIX} > > > nscd${PKGSUFFIX} ldd${PKGSUFFIX} ${PN}-utils ${PN}-pic ${PN}-dev > > > eglibc-doc > > > libcidn libmemusage libsegfault${PKGSUFFIX} eglibc-extra-nss > > > eglibc-thread-db${PKGSUFFIX} eglibc-pcprofile" > > > > > > You seem to have made a bunch of changes here that are not related to > > > locales. > > > What are those about? > > > > They are locale related changes. > > Locale related stuffs in the above PACKAGES and PACKAGES_DYNAMIC are moved > > to eglibc-locale recipe. > > Is libsotruss${PKGSUFFIX} (for example) really a "locale related stuff"? > It's not obvious to me what the connection is.
Dongxiao: What Phil is referring to here is that libsotruss${PKGSUFFIX} disappeared from PACKAGES and that also "${libdir}/audit/.debug" disappeared from FILES_${PN}-dbg. Specifically these changes came in as part of: http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=77c2dd944db42e40cc8467e6bc5a175fed90c251 which I don't think your patch accounted for. Since this patch has been around for a while and it otherwise looks good, I've fixed up these couple of issues and merged it though. Cheers, Richard _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core