On Thu, Sep 22, 2011 at 9:17 AM, Koen Kooi <k...@dominion.thruhere.net> wrote: > > Op 22 sep. 2011, om 15:00 heeft Dmitry Eremin-Solenikov het volgende > geschreven: > >> On 09/22/2011 04:35 PM, Koen Kooi wrote: >>> >>> Op 22 sep. 2011, om 14:25 heeft Dmitry Eremin-Solenikov het volgende >>> geschreven: >>> >>>> On 09/18/2011 02:23 AM, Otavio Salvador wrote: >>>>> I have sent this in July and it was nacked. See at >>>>> https://github.com/OSSystems/oe-core/commit/5c53cbf951a11ed92fb2ad0837991db256c11489 >>>> >>>> Answering the original question by Saul: >>>> A possible better question is why perf-dbg is getting generated and what's >>>> in it? >>>> >>>> perf and perf-dbg are generated to contain perf tool if it's not directly >>>> enabled (AFAIK), but you can compile it by running make in tools/perf. It >>>> has some additional depends (like binutils-dev, elfutils-dev, news-dev, >>>> etc., so it's not enabled by default. Probably we should enable it though. >>> >>> the oe core kernel.bbclass builds perf by default >> >> according to kernel.bbclass: "perf must be enabled in individual kernel >> recipes" > > And pretty much everything uses recipes-kernel/linux/linux-tools.inc, which > enables it. I had to add do_compile_perf() { : } to my old kernel recipes > that have a broken perf, so it's opt-out, not opt-in.
We can always flip this around if required. When I initially did the kernel tree based builds for perf it was right in a specific kernel recipe, and then pulled it out into linux-tools.inc for easier reuse it was the intention that just including/requiring that .inc file would trigger a build of perf. I'm open to inhibiting this via the blacklist or via some other suitable mechanism. But did we get some include creep (or maybe I'm just missing it) ? When I just checked my tree, I only see a handful of places that linux-tools.inc will be pulled in and trigger a build. Cheers, Bruce > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core > -- "Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end" _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
