On 25.08.2017 21:59, Martin Jansa wrote: > Does the patch cause any harm when used on newer kernel?
Based on my limited testing on our devices running kernel 4.11.0, no. > > If so shouldn't the patch be fixed to work correctly even with newer > kernel? > > Or what's the main reason to remove it? I am going through each and every patch that we carry on our layers. If upstreaming status is pending, we try to upstream it. If the patch is no longer needed, we remove it. When I came across this particular patch, I thought it was obsolete and that it should be removed upstream too. I was not aware of OLDEST_KERNEL. I will send a revert now. Thanks, -- Jose > > On Fri, Aug 25, 2017 at 8:55 PM, Mark Hatle <mark.ha...@windriver.com > <mailto:mark.ha...@windriver.com>> wrote: > > On 8/25/17 1:48 PM, Andre McCurdy wrote: > > On Fri, Aug 25, 2017 at 12:09 AM, Jose Alarcon > <jose.alar...@ge.com <mailto:jose.alar...@ge.com>> wrote: > >> On 24.08.2017 20 <tel:24.08.2017%2020>:45, Andre McCurdy wrote: > >>> On Wed, Aug 23, 2017 at 10:37 PM, Jose Alarcon > <jose.alar...@ge.com <mailto:jose.alar...@ge.com>> wrote: > >>>> This patch was a temporal workaround needed with 4.1 kernels. > >>>> Remove it. > >>> OLDEST_KERNEL is still set to 3.2.0 > >>> > >>> How can you be sure nobody is using 4.1 ? > >> > >> That's a good point! > >> > >> I didn't know about this variable. I believe we should not > integrate > >> this change. > >> I will resend it once OLDEST_KERNEL is set to 4.2 or bigger. > > > > The original patch has been merged to master so a second patch > will be > > needed to revert it. > > > > It may make sense to selectively apply the patch based on what > OLDEST_KERNEL is > set to. > > This way if a user or distribution sets a newer 'OLDEST_KERNEL', > that item can > be removed automatically. > > --Mark > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > <mailto:Openembedded-core@lists.openembedded.org> > http://lists.openembedded.org/mailman/listinfo/openembedded-core > <http://lists.openembedded.org/mailman/listinfo/openembedded-core> > > -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
