On Wed, 2011-10-12 at 09:40 -0500, Mark Hatle wrote:
> > --- a/bitbake/lib/bb/runqueue.py
> > +++ b/bitbake/lib/bb/runqueue.py
> > @@ -1096,6 +1096,10 @@ class RunQueueExecute:
> >
> > logger.debug(2, 'Running %s:%s under fakeroot, fakedirs: %s' %
> > (fn, taskname, ', '.join(fakedirs)))
> > + else:
> > + envbackup["PSEUDO_RELOADED"] =
> > os.environ.get("PSEUDO_RELOADED")
> > + os.environ["PSEUDO_RELOADED"] = "yes"
> > + fakeenv["PSEUDO_RELOADED"] = "yes"
>
> PSEUDO_RELOADED was intended to only be used internally by pseudo.
> Specifically
> to signify to fork/exec that we're about to run the pseudo server process and
> to
> remove PSEUDO from the LD_PRELOAD on the next fork/exec.
Right, I realised I was abusing it here, its good for a performance
measurement though ;-)
> The system simply checks the environment on the fork-exec and doesn't check
> the
> value on pseudo-load. This is why it works.
>
> That side effect means that any subsequent calls can NOT re-enable pseudo as
> it's no longer in memory at all.
>
> So what you are seeing at best is the time difference from avoiding the
> LD_PRELOAD and the jump table setup. (Even when pseudo is disabled, we need
> to
> enable the jump table, we just pass the call to the original function.)
>
> But more then likely because pseudo is no longer memory resident for the
> called
> processes and it's sub-processes.. there is likely some place in the system
> that
> uses pseudo functionality that is no longer functioning properly.
I'm not sure that there is in our use cases. If we need pseudo
functionality the tasks are marked as "fakeroot" with a flag. If that
flag is not set (which is when the above code triggers), its perfectly
fine to have pseudo unload at the next exec.
> It would be interesting to determine first off, if there is anywhere pseudo
> should be running that it currently isn't. And second if this is simply due
> to
> LD_PRELOAD time, or if enabling the jump table is the culprit.
>
> One potential optimization, when PSEUDO_DISABLE=1 is to only setup the jump
> table entries for fork/exec items.
Agreed, I don't know where the time is being spent exactly at this
point. I do know we execute an absolute ton of exec/fork calls so
removing any overhead from them will improve our speed though. This
change means do_configure won't run with pseudo enabled for example
which is a very exec heavy task.
> Also if it is desired to unload pseudo, I'd suggest we add a new environment
> variable to pseudo that is specific about unloading pseudo, instead of using
> the
> existing PSEUDO_RELOADED. Not only is the name confusing, but since it's an
> internal item it's behavior may change or go away in the future.
>
> (Below is from the pseudo man page:
>
> PSEUDO_RELOADED
> This purely internal variable is used to track state while try-
> ing to re-execute to get rid of the LD_PRELOAD value when
> spawning a server. (The pseudo server itself cannot function
> running in the pseudo environment.)
> )
I suspect we may need a dedicated option for this...
Cheers,
Richard
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
