Hi, On Thu, 2018-05-17 at 14:29 +0800, ChenQi wrote: > Hi, > > I've also noticed this problem. The growing testdata.json files also > bothered me a little bit. > > I think the only small flaw with your patch is you deleted the following > check. > > if testdata_link != testdata: > > Checking the values of IMAGE_NAME and IMAGE_LINK_NAME in bitbake.conf, > such check seems not necessary. > But these values could be overridden. How about still keeping such check?
I made this fragment identical to all other uses of IMAGE_LINK_NAME and IMAGE_LINK within this class. None of the other uses have such a test, so it doesn't seem to make sense to have this check in write_image_test_data() either. Cheers, Andre' -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
