On Tue, 2018-05-22 at 13:48 +0100, André Draszik wrote: > > Have you looked at the performance impact of this change? It looks > > like > > it will be compiling the regexp each time inside a tight loop which > > gets called once per task dependency which will show up > > significantly > > on the performance chart. > True, and no, I haven't. Is there a good way to compare the > performance with > and without this change other than using 'time'?
I'd try something like "bitbake <image> -P -n" which should generate a profile output for the dry run of building the image. That would not build anything but would include all the dependency calculations (and unfortunately all the fork overheadin this case). > > > > We already have a "*" syntax used in > > SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS > > and I'd rather use that syntax here to avoid the use of re if we > > can > > help it. Could you see if that is possible please? That would also > > keep > > the syntax compatible. > OK. I think it uses glob btw which is much lighter weight than re. Cheers, Richard -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core