> -----Original Message----- > From: Andre McCurdy <armccu...@gmail.com> > Sent: den 22 augusti 2018 01:37 > To: Peter Kjellerstedt <peter.kjellerst...@axis.com> > Cc: Richard Purdie <richard.pur...@linuxfoundation.org>; Andrej Valek > <andrej.va...@siemens.com>; openembedded-core@lists.openembedded.org > Subject: Re: [OE-core] [PATCH v2] busybox: update to 1.29.1 > > On Tue, Aug 21, 2018 at 3:48 PM, Peter Kjellerstedt > <peter.kjellerst...@axis.com> wrote: > >> -----Original Message----- > >> From: openembedded-core-boun...@lists.openembedded.org <openembedded- > >> core-boun...@lists.openembedded.org> On Behalf Of Richard Purdie > >> Sent: den 21 augusti 2018 22:30 > >> To: Andrej Valek <andrej.va...@siemens.com>; openembedded- > >> c...@lists.openembedded.org > >> Subject: Re: [OE-core] [PATCH v2] busybox: update to 1.29.1 > >> > >> On Fri, 2018-08-17 at 10:18 +0200, Andrej Valek wrote: > >> > ping > >> > >> Fails to build on the autobuilder due to missing crypt headers. > >> That is probably a missing DEPENDS > > > > Well, the patch I sent to add a dependency on virtual/crypt will > > solve this, but see below. > > > >> but I'm wondering what changed and if the > >> change was intentional. > > > > The change was intentional, but it should have been conditional. > > libbb/pw_encrypt.c now unconditionally includes crypt.h, but it > > should only include it if ENABLE_USE_BB_CRYPT is not set: > > > > diff --git a/libbb/pw_encrypt.c b/libbb/pw_encrypt.c > > index 86455cd0d..47c20690f 100644 > > --- a/libbb/pw_encrypt.c > > +++ b/libbb/pw_encrypt.c > > @@ -6,7 +6,9 @@ > > * > > * Licensed under GPLv2 or later, see file LICENSE in this source tree. > > */ > > +#if !ENABLE_USE_BB_CRYPT > > #include <crypt.h> > > +#endif > > #include "libbb.h" > > Do you plan to submit the fix upstream?
I had not planned on it, no... > > /* static const uint8_t ascii64[] ALIGN1 = > > > >> https://autobuilder.yocto.io/builders/nightly-x86/builds/1259/steps/BuildImages/logs/stdio > >> > >> https://autobuilder.yocto.io/builders/nightly-x32/builds/1225/steps/BuildImages/logs/stdio > >> > >> and more... > >> > >> Cheers, > >> > >> Richard > > > > //Peter //Peter -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core