On Wed, 16 Jan 2019 at 09:37, <changqing...@windriver.com> wrote:
> +SDK_TAR_TYPE ?= "tar.xz"
> +SDK_TAR_DEPENDS ?= "xz-native"
> +SDK_TAR_CMD ?= "tar ${SDKTAROPTS} -cf - . | xz -T 0 >
> ${SDKDEPLOYDIR}/${TOOLCHAIN_OUTPUTNAME}.${SDK_TAR_TYPE}"
Don't call these SDK_TAR because they might not be generating a
tarball. How about SDK_ARCHIVE_*
Using overrides or flags would let you put the zip logic into oe-core
too, because it is feasible that more than meta-mingw will want to use
zip archives.
Also, add a comment about the expected behaviour of the CMD,
specifically what the input variables are and where the output should
go. Bonus points fo refactoring slightly so the command is passed an
absolute input directory, and absolute output filename.
Ross
--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
