On Fri, 12 Apr 2019 at 10:57, Zheng, Ruoqin <zhengrq.f...@cn.fujitsu.com> wrote:
> > >         echo 'export OECORE_DISTRO_VERSION="${DISTRO_VERSION}"' >>
> > > $script
> > > +       echo 'export MACHINE_ARCH=${MACHINE_ARCH}' >> $script
> > > Please explain why this change in the commit.
>
> Dnf is based on rpm and rpm need to read the arch info, but $script did not 
> provide it. So I added it.

Please make a separate commit for this then.

> > > Do not copy-paste large chunks like this please. Assign the
> > > dependencies to a variable, and use it where needed.
>
> If so, how about this way?
>
> BBCLASSEXTEND = "native nativesdk"
>
> RDEPENDS_${PN} += " \
>    python3-core \
>    ......
>    "
>
> RDEPENDS_${PN}_class-native = ""

Yes, this should work. There is an issue with class-native RDEPENDS,
where you can put recipe names in it, but not package names (because
there are no packages created for -native). I wrote about it here:
http://lists.openembedded.org/pipermail/openembedded-core/2019-March/280618.html

Alex
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Reply via email to