Hi, Richard > Whilst I can guess why, its not obvious at all the dnf needs > MACHINE_ARCH. I'd probably be happier with a better variable name. > Which code exactly is using it?
Arch information is necessary for rpm. As what do for dnf-native in _configure_rpm function, nativesdk-dnf has to do the same work. But the environment for nativesdk doesn't supply arch information. I think MACHINE_ARCH is suitable to supply arch information for nativesdk. How about your Opinion? Best regards Lei > -----Original Message----- > From: richard.pur...@linuxfoundation.org > [mailto:richard.pur...@linuxfoundation.org] > Sent: Tuesday, June 04, 2019 6:26 PM > To: Lei, Maohui > Cc: openembedded-core@lists.openembedded.org > Subject: Re: [OE-core] [PATCH] toolchain-scripts: make rpm work in toolchain > > On Tue, 2019-06-04 at 08:29 +0000, Lei, Maohui wrote: > > Hi Richard > > > > This patch is necessary for dnf-nativesdk which has been merged. But > > this patch is still ignored. > > Do you have any comment about this patch? > > Basically I really don't like exporting "random" variables in the SDK, > particularly when the meaning/use of them isn't clear. > > Whilst I can guess why, its not obvious at all the dnf needs > MACHINE_ARCH. I'd probably be happier with a better variable name. > Which code exactly is using it? > > Cheers, > > Richard > > -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
