On 06/28/2019 07:25 AM, Paul Eggleton wrote:
On Thursday, 27 June 2019 3:14:55 PM NZST Chen Qi wrote:
Currently `devtool finish RECIPE meta' will silently succeed even
if there are multiple layers having the same base name of 'meta'.
e.g. meta layer from oe-core and meta layer from meta-secure-core.
Good catch!
We should at least give user a warning in such case. With the patch,
we will get warning like below.
WARNING: Multiple layers have the same base name 'meta', use the first one
'<PROJ_DIR>/oe-core/meta'.
WARNING: Consider using path instead of base name to specify layer:
<PROJ_DIR>/oe-core/meta
<PROJ_DIR>/meta-secure-core/meta
"use the first one" -> "using the first one"
However I'm wondering if this is the right behaviour. What if the user realises
they actually wanted the second one? Given it's a warning the finish operation
would have proceeded and the user will have to clean things up manually. Rather
than a warning, should we in fact be erroring out and requiring the user to be
more specific in this case?
Cheers,
Paul
More reasonable. I'll send out V2.
Best Regards,
Chen Qi
--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
