On Thu, 2019-07-18 at 17:18 +0800, Jun Nie wrote: > <[email protected]> 于2019年7月17日周三 下午7:41写道： > > On Wed, 2019-07-10 at 15:10 +0800, Jun Nie wrote: > > > u-boot.bin with dtb & signature should be placed in ${B} so that > > > it can be deployed by u-boot as expected. Otherwise, the version > > > without signature is installed. > > > > > > Signed-off-by: Jun Nie <[email protected]> > > > --- > > > meta/classes/uboot-sign.bbclass | 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > I continue to be very worried we have no test coverage in this area > > of > > the code. Since I don't know it particularly well I'm effectively > > merging patches blindly :(. > > Then I think you can merge it as long as it pass current test > coverage. Because I already test the FIT signature feature comes back > with this patch :-)
It has merged but my point is we really need better test coverage of these areas of the code. What I'd really like is for people to help write tests which showed the broken behaviour the patch is fixing. Cheers, Richard -- _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
