On Friday, 9 August 2019 8:27:24 AM NZST Alexander Kanavin wrote: > On Thu, 8 Aug 2019 at 22:17, Manjukumar Harthikote Matha < > [email protected]> wrote: > > Any update on this? Is there a reason not to merge this feature? > > For what it's worth I am firmly in the camp that finds the non-deletion of > sources annoying. When I run 'devtool reset', there is never any unsaved > work left in there, but I am in too much of a hurry to do the extra 'rm' on > those sources, and so much later (sometimes months later) it has to be done > just prior to starting work on something else entirely (but with the same > upstream component).
My apologies for not acting upon this earlier - I'm coming around to the realisation that most people want this feature and won't blame the tool if they invoke it when they didn't mean to ;) Chandana / Manju, overall the patch is good, but could you please make the following revisions: 1) Also add the exact same option to devtool finish (since it's the other path for recipes leaving the workspace) 2) Add some testing in oe-selftest that verifies that: (a) it devtool does not delete the source by default (this could be tacked onto an existing test) and (b) that it does delete it with the option specified (could also be tacked onto another existing test if it doesn't adversely affect it). 3) The prefix to the shortlog should be "devtool:" not "standard.py:" - this is a more useful functional area description to help identify what's being changed. Thanks Paul -- Paul Eggleton Intel Open Source Technology Centre -- _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
