On Sat, Feb 15, 2020 at 08:07:34AM +0000, Richard Purdie wrote:
> On Thu, 2020-02-13 at 10:31 +0800, Kevin Hao wrote:
> > APPEND is used to add additional parameters to kernel by features,
> > such
> > as read-only-rootfs. So we should honor this variable when we compose
> > the kernel parameter in wic. I know we also can resolve this kind of
> > issue by using the .wks.in template introduced by commit 42e870c5ed4b
> > ("image_types.bbclass: support template .wks.in files for wic"), but
> > the
> > APPEND is needed by all the wks, it would seems pretty ridiculous to
> > me
> > to change all the .wks to .wks.in and then foist the APPEND into
> > them.
> > So the APPEND is definitely deserved to export to the wic directly.
> >
> > [Yocto #12809]
> >
> > Signed-off-by: Kevin Hao <kexin....@windriver.com>
> > ---
> > meta/classes/image_types_wic.bbclass | 2 +-
> > scripts/lib/wic/ksparser.py | 5 +++++
> > 2 files changed, 6 insertions(+), 1 deletion(-)
>
> This seems to cause a selftest failure:
>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/80/builds/688
>
> oe-selftest -r wic.Wic2.test_image_envThe APPEND is optional, so I should add it in the optional variables list in wic.Wic2.test_image_env. The fix is coming soon. Thanks, Kevin > > Cheers, > > Richard >
signature.asc
Description: PGP signature
-- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
