On Wed, Apr 15, 2020 at 4:20 PM Ross Burton <r...@burtonini.com> wrote: > > On Wed, 15 Apr 2020 at 01:47, Andreas M?ller <schnitzelt...@gmail.com> wrote: > > Am testing it currently but what do experts think of > > > > diff --git a/meta/classes/meson.bbclass b/meta/classes/meson.bbclass > > index 06034e8b47..167263f76c 100644 > > --- a/meta/classes/meson.bbclass > > +++ b/meta/classes/meson.bbclass > > @@ -68,6 +68,9 @@ def meson_operating_system(var, d): > > os = d.getVar(var) > > if "mingw" in os: > > return "windows" > > + # avoid e.g 'linux-gnueabi' > > + elif "linux" in os: > > + return "linux" > > else: > > return os > > Looks right. The canonical table of OS names for Meson is here: > > https://mesonbuild.com/Reference-tables.html#operating-system-names ^ Thanks - was looking for that exactly that. Will send out a patch soon
> There's an argument to be made for validating the OS name is in that > list before returning it from meson_operating_system. ^ I read this several times - but am not sure if understand it correctly: Do you mean it is not correct/expected that meson accepts an incorrect name? Andreas > > Ross
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#137244): https://lists.openembedded.org/g/openembedded-core/message/137244 Mute This Topic: https://lists.openembedded.org/mt/73023862/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
