On Fri, 2020-04-24 at 13:59 +0000, chris.lapla...@agilent.com wrote: > > > So, is changing DISTRO_FEATURES but not changing the build > > > directory > > > expected to work? > > > > Should work but has bugs. > > > > There were some fixed around the thud/zeus timeframe. > > > > https://bugzilla.yoctoproject.org/show_bug.cgi?id=13702 > > > > is a recently reported one that has patches in master-next (both to > > fix and > > add a test case). > > > > Is there a failure with reproducer you have? Which release? > > I haven't encountered any bugs yet, no. I am working on adding some > custom DISTRO_FEATURES to our distro. I was trying to convince myself > whether vardeps are necessary for DISTRO_FEATURES, and couldn't > decide. For instance, if I have: > > do_unpack_append() { > echo "${@bb.utils.contains("DISTRO_FEATURES", "my-feature", > "true", "false", d)}" >> ${S}/whatever > } > > bitbake-dumpsigs on the do_unpack sigdata reveals that > DISTRO_FEATURES is *not* part of the task dependencies. So I was > wondering if I needed to do: > > do_unpack[vardeps] += "DISTRO_FEATURES" > > but looking around poky and meta-openembedded, I don't see anyone > else doing that kind of thing. > > The interesting thing is that the bitbake-dumpsig does have some > special looking DISTRO_FEATURES output, such as: > > DISTRO_FEATURES{usrmerge} = Unset > DISTRO_FEATURES{my-feature} = Set > > So it seems there is some DISTRO_FEATURES specific processing? > > It's also unclear to me whether the signature code is able to > understand bb.utils.contains and automatically pluck out the fact > that DISTRO_FEATURES should be accounted for.
"contains" has special magic where it caches the specific value presence rather than the whole string. I'd therefore recommend using the contains functions where at all possible for that reason. Cheers, Richard
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#137448): https://lists.openembedded.org/g/openembedded-core/message/137448 Mute This Topic: https://lists.openembedded.org/mt/73225609/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
