On 04/09/2020 13.51, Richard Purdie wrote: > On Fri, 2020-09-04 at 09:08 +0200, Rasmus Villemoes wrote: >> Not every image necessarily wants a timestamp file, > > Wouldn't you just not have rootfs_update_timestamp in > ROOTFS_POSTPROCESS_COMMAND in that case?
Perhaps, but removing stuff from ROOTFS_POSTPROCESS_COMMAND is a little tedious and error-prone, 8c835f63 isn't all that old. And with the other use case in mind, it really isn't a lot of extra logic to assign a meaning to ROOTFS_TIMESTAMP_FILE being empty. > > I have a feeling there are other consumers of this file which would > also need to be changed to reference ROOTFS_TIMESTAMP_FILE? Well, there are two files associated to the initscripts recipe mentioning it, and a mention in devtool. But I don't imagine ROOTFS_TIMESTAMP_FILE being set globally, it's really something one can set in individual image recipes for images that don't create an ordinary linux rootfs (e.g. bootfiles for RPi). Dunno, if somebody sets ROOTFS_TIMESTAMP_FILE for their proper rootfs and also include the initscripts package in that rootfs, I suppose they should match, but I don't know where one should set the variable. Btw., is there some good reason that by default, with reprocible_builds turned on, the rootfs gets two files with the exact same content (/etc/timestamp and /etc/version)? Because we'll need to fix (or avoid) the creation of /etc/version in the same way for some of our images. Rasmus
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#142250): https://lists.openembedded.org/g/openembedded-core/message/142250 Mute This Topic: https://lists.openembedded.org/mt/76624850/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
