On Thu, Sep 17, 2020 at 04:45:34PM +0200, Jens Rehsack wrote: > From: Jens Rehsack <[email protected]> > > Since the newly introduced image-artifact-names class is inherited at later > processing stage, individual IMAGE_NAME settings are overridden (hopefully > by accident instead on purpose).
The purpose was was to make it easier for DISTRO to define own scheme, so LGTM. You can still override the values from distro layer, but I agree that this makes it a bit easier to do that, thanks! > Allow derived distributions define their own name schema by setting defaults > iwth question mark. > > Signed-off-by: Jens Rehsack <[email protected]> > --- > meta/classes/image-artifact-names.bbclass | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/meta/classes/image-artifact-names.bbclass > b/meta/classes/image-artifact-names.bbclass > index 5ab8f1b7aa..3ac8dd731a 100644 > --- a/meta/classes/image-artifact-names.bbclass > +++ b/meta/classes/image-artifact-names.bbclass > @@ -2,11 +2,11 @@ > # Specific image creation and rootfs population info. > ################################################################## > > -IMAGE_BASENAME = "${PN}" > -IMAGE_VERSION_SUFFIX = "-${DATETIME}" > +IMAGE_BASENAME ?= "${PN}" > +IMAGE_VERSION_SUFFIX ?= "-${DATETIME}" > IMAGE_VERSION_SUFFIX[vardepsexclude] += "DATETIME" > -IMAGE_NAME = "${IMAGE_BASENAME}-${MACHINE}${IMAGE_VERSION_SUFFIX}" > -IMAGE_LINK_NAME = "${IMAGE_BASENAME}-${MACHINE}" > +IMAGE_NAME ?= "${IMAGE_BASENAME}-${MACHINE}${IMAGE_VERSION_SUFFIX}" > +IMAGE_LINK_NAME ?= "${IMAGE_BASENAME}-${MACHINE}" > > # IMAGE_NAME is the base name for everything produced when building images. > # The actual image that contains the rootfs has an additional suffix (.rootfs > -- > 2.17.1 >
signature.asc
Description: PGP signature
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#142637): https://lists.openembedded.org/g/openembedded-core/message/142637 Mute This Topic: https://lists.openembedded.org/mt/76910520/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
