On Tue, 2021-02-23 at 22:01 -0500, Randy MacLeod wrote: > Clean-up the merge of meta-rust to oe-core by squashing most of the > meta-rust history so we are left with: > > 35da4b252f rust: add a language demo image to test reproducibility > 088374371b cargo/rust/rustfmt: exclude from world > 7df10d2a22 meta-rust: merge commits > 4187796cd6 rust: mv README.md to recipes-devtools/rust/README-rust.md > 03b9c60ef4 meta-rust: move code to oe-core from meta-rust layer > 2c62874204 libgit2: pull in updates from meta-oe > 24cb3db88c libssh2: pull in additional commits from meta-oe > e9a0a3bad2 Add libgit2, libssh2 from meta-oe for rust > > The full diffstat is below. (1) > > I didn't really notice the scripts shown below since they are mostly harmless. > I'll review them and remove them in v2 if they don't make sense for oe-core.
This is better, thanks. My feedback from a quick glance: a) Need maintainer entries for the new recipes b) The scripts in scripts/ look at the very least inappropriately named for OE-Core, I suspect we don't want/need those. c) Not entirely sure about the languages demo image, its not how we test any other language d) There aren't any tests in meta/lib/oeqa! e) The rust README starts "This OpenEmbedded layer provides" and has a few other issues. Cheers, Richard
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#148544): https://lists.openembedded.org/g/openembedded-core/message/148544 Mute This Topic: https://lists.openembedded.org/mt/80869121/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
