Hi Richard, On Thu, 25 Feb 2021 21:47:24 +0000 Richard Purdie <[email protected]> wrote: > On Thu, 2021-02-25 at 16:38 -0500, Vivien Didelot wrote: > > Sort packages in RRECOMMENDS_${PN}-container alphabetically to avoid > > subjective sorting and ease future additions. > > > > Signed-off-by: Vivien Didelot <[email protected]> > > --- > > meta/recipes-core/systemd/systemd_244.5.bb | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/meta/recipes-core/systemd/systemd_244.5.bb > > b/meta/recipes-core/systemd/systemd_244.5.bb > > index 70700820d7..aaed047e63 100644 > > --- a/meta/recipes-core/systemd/systemd_244.5.bb > > +++ b/meta/recipes-core/systemd/systemd_244.5.bb > > @@ -447,9 +447,9 @@ FILES_${PN}-container = > > "${sysconfdir}/dbus-1/system.d/org.freedesktop.import1.c > > " > > > > > > > > > > RRECOMMENDS_${PN}-container += "\ > > - ${PN}-journal-upload \ > > - ${PN}-journal-remote \ > > ${PN}-journal-gatewayd \ > > + ${PN}-journal-remote \ > > + ${PN}-journal-upload \ > > " > > > > > > These look like ok changes to me but they're against an older version of > systemd, we currently have 247.3 in master. Would you be able to send > against that version please?
Oops, I based my patches against latest "dunfell". They do apply cleanly on latest master though (containing systemd_247.3.bb). Do you wish me to resend them anyway? Also regarding patch 2/3, I placed "tar" in RRECOMMENDS because one can use machinectl without the "import-tar" subcommand, but one could argue that this subcommand is broken without a version of tar supporting --numeric-owner, thus could be a candidate for RDEPENDS. What is your view on this? Thank you, Vivien
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#148708): https://lists.openembedded.org/g/openembedded-core/message/148708 Mute This Topic: https://lists.openembedded.org/mt/80913358/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
