On Mon, 2021-03-29 at 16:00 -0700, Andre McCurdy wrote: > On Mon, Mar 29, 2021 at 3:45 PM Devendra Tewari > <devendra.tew...@gmail.com> wrote: > > > > Thanks! My bad. The example I looked up in Python docs had a break and I > > just realized it was a looping example. > > > > Here’s the updated patch (or should I submit it again via git send-email?) > > It would be better to use shutil.move unconditionally in all cases, > rather than have a separate shutil.move code path which only gets > tested by people doing incremental builds in docker.
This is a speed sensitive section of code and shutil has traditionally proved to be slow so I disagree with that, rename is very much preferred here where we can. Cheers, Richard
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#150073): https://lists.openembedded.org/g/openembedded-core/message/150073 Mute This Topic: https://lists.openembedded.org/mt/81698791/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
