On Fri, 2021-10-15 at 15:39 +0100, Mike Crowe via lists.openembedded.org wrote: > Extract package_qa_write_error, package_qa_handle_error and > package_qa_add_message functions from insane.bbclass to lib/oe/qa.py and > drop the package_qa_ prefixes. > > Update various bbclasses to use the new functions. No import is required > since base.bbclass puts oe.qa in OE_IMPORTS. > > Stop requiring callers to manually track whether a fatal error has been > encountered via a "sane" flag. Instead replace the QA_SANE variable with > QA_ERRORS_FOUND and call oe.qa.exit_if_errors or > oe.qa.exit_with_message_if_errors at the end of each task. > > Inspired by discussion resulting from > https://lists.openembedded.org/g/openembedded-core/message/156793 and > https://lists.openembedded.org/g/openembedded-core/message/156900 > > Signed-off-by: Mike Crowe <m...@mcrowe.com> > --- > meta/classes/buildhistory.bbclass | 3 +- > meta/classes/insane.bbclass | 180 ++++++++++++------------------ > meta/classes/multilib.bbclass | 3 +- > meta/classes/package.bbclass | 26 ++--- > meta/classes/ptest.bbclass | 2 +- > meta/lib/oe/qa.py | 34 ++++++ > 6 files changed, 120 insertions(+), 128 deletions(-)
There was an indentation issue with multilib.bbclass but I fixed that and now have merged this, thanks. I think you are right about there being legacy reasons for collecting up the messages and the "sane" variable tracking so if you are feeling keen (or anyone else is) further cleanup of this code is very welcome. Cheers, Richard
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#157032): https://lists.openembedded.org/g/openembedded-core/message/157032 Mute This Topic: https://lists.openembedded.org/mt/86340591/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
