I think the whole line doesn't have to match, it's enough if the string is in it somewhere. You can verify by making the message even shorter, and checking that it still works.
Alex On Thu, 28 Oct 2021 at 12:15, Teoh, Jay Shen <jay.shen.t...@intel.com> wrote: > "[drm] Cannot find any crtc or sizes", > "[drm] Cannot find any crtc or sizes - going 1024x768", > > > > Both lines are covering difference case, the first line covers the case > when no fallback size is set, and second line covers the case when fallback > size is set. > > > > Thanks, > > Jay > > > > *From:* Alexander Kanavin <alex.kana...@gmail.com> > *Sent:* Thursday, 28 October, 2021 6:10 PM > *To:* Teoh, Jay Shen <jay.shen.t...@intel.com> > *Cc:* Khem Raj <raj.k...@gmail.com>; Jose Quaresma < > quaresma.j...@gmail.com>; OE-core < > openembedded-core@lists.openembedded.org> > *Subject:* Re: [OE-core] [PATCH] oeqa/runtime/parselogs: whitelist drm > failure in common errors list > > > > But then you can remove the previous line, right? > > > > Alex > > > > On Thu, 28 Oct 2021 at 12:08, Teoh, Jay Shen <jay.shen.t...@intel.com> > wrote: > > > > > -----Original Message----- > > From: Khem Raj <raj.k...@gmail.com> > > Sent: Thursday, 28 October, 2021 12:17 AM > > To: Jose Quaresma <quaresma.j...@gmail.com> > > Cc: Teoh, Jay Shen <jay.shen.t...@intel.com>; OE-core <openembedded- > > c...@lists.openembedded.org> > > Subject: Re: [OE-core] [PATCH] oeqa/runtime/parselogs: whitelist drm > failure in > > common errors list > > > > On Wed, Oct 27, 2021 at 2:24 AM Jose Quaresma <quaresma.j...@gmail.com> > > wrote: > > > > > > > > > > > > Teoh, Jay Shen <jay.shen.t...@intel.com> escreveu no dia quarta, > > 27/10/2021 à(s) 10:12: > > >> > > >> From: Teoh Jay Shen <jay.shen.t...@intel.com> > > >> > > >> Add the following line to common_errors list. > > >> > > >> [drm] Cannot find any crtc or sizes > > >> > > >> This message is not harmful, it extended the coverage for drm error > message. > > >> > > >> Signed-off-by: Teoh Jay Shen <jay.shen.t...@intel.com> > > >> --- > > >> meta/lib/oeqa/runtime/cases/parselogs.py | 1 + > > >> 1 file changed, 1 insertion(+) > > >> > > >> diff --git a/meta/lib/oeqa/runtime/cases/parselogs.py > > b/meta/lib/oeqa/runtime/cases/parselogs.py > > >> index 2b8893d842..96da0b4f5c 100644 > > >> --- a/meta/lib/oeqa/runtime/cases/parselogs.py > > >> +++ b/meta/lib/oeqa/runtime/cases/parselogs.py > > >> @@ -32,6 +32,7 @@ common_errors = [ > > >> "Failed to load module \"fbdev\"", > > >> "Failed to load module fbdev", > > >> "Failed to load module glx", > > >> + "[drm] Cannot find any crtc or sizes", > > >> "[drm] Cannot find any crtc or sizes - going 1024x768", > > > > > > > > > I think this one ^ can be removed > > > > will the first entry cover the case when a fallback size is set ? > > In that case, it won't cover it. That's why I am adding a new line to > expand the coverage > > > > > > > > >> > > >> "_OSC failed (AE_NOT_FOUND); disabling ASPM", > > >> "Open ACPI failed (/var/run/acpid.socket) (No such file or > directory)", > > >> -- > > >> 2.33.1 > > >> > > >> > > >> > > >> > > > > > > > > > -- > > > Best regards, > > > > > > José Quaresma > > > > > > > > > > > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#157590): https://lists.openembedded.org/g/openembedded-core/message/157590 Mute This Topic: https://lists.openembedded.org/mt/86623483/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
