On Wed, Jan 12, 2022 at 12:30 PM Khem Raj <raj.k...@gmail.com> wrote:
>
>
>
> On 1/12/22 1:07 AM, Kevin Hao wrote:
> > The crc extension is optional for the ARMv8.0 but is mandatory for the
> > cortexa72, so there is no reason not to enable it for the cortexa72
> > tune. With this change, the cortexa72-crc seems redundant. But we
> > had better to keep it to be compatible with the BSP which already used
> > that tune.
>
> this looks good. Is there a way to warn such users to migrate to better
> option ?
We could just remove the crc and when it breaks they'll look....
>
> >
> > Signed-off-by: Kevin Hao <kexin....@windriver.com>
> > ---
> > .../machine/include/arm/armv8a/tune-cortexa72.inc | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc
> > b/meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc
> > index 3651cf6e802b..4c9add32f5f5 100644
> > --- a/meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc
> > +++ b/meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc
> > @@ -10,12 +10,12 @@ AVAILTUNES += "cortexa72 cortexa72-crc
> > cortexa72-crc-crypto"
> > ARMPKGARCH:tune-cortexa72 = "cortexa72"
> > ARMPKGARCH:tune-cortexa72-crc = "cortexa72"
> > ARMPKGARCH:tune-cortexa72-crc-crypto = "cortexa72"
> > -TUNE_FEATURES:tune-cortexa72 = "${TUNE_FEATURES:tune-armv8a}
> > cortexa72"
> > -TUNE_FEATURES:tune-cortexa72-crc = "${TUNE_FEATURES:tune-cortexa72}
> > crc"
> > -TUNE_FEATURES:tune-cortexa72-crc-crypto =
> > "${TUNE_FEATURES:tune-cortexa72} crc crypto"
> > -PACKAGE_EXTRA_ARCHS:tune-cortexa72 =
> > "${PACKAGE_EXTRA_ARCHS:tune-armv8} cortexa72"
> > -PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc =
> > "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc} cortexa72 cortexa72-crc"
> > -PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc-crypto =
> > "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc-crypto} cortexa72 cortexa72-crc
> > cortexa72-crc-crypto"
> > +TUNE_FEATURES:tune-cortexa72 = "${TUNE_FEATURES:tune-armv8a-crc}
> > cortexa72"
> > +TUNE_FEATURES:tune-cortexa72-crc = "${TUNE_FEATURES:tune-cortexa72}"
> > +TUNE_FEATURES:tune-cortexa72-crc-crypto =
> > "${TUNE_FEATURES:tune-cortexa72} crypto"
> > +PACKAGE_EXTRA_ARCHS:tune-cortexa72 =
> > "${PACKAGE_EXTRA_ARCHS:tune-armv8-crc} cortexa72"
> > +PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc =
> > "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc} cortexa72"
> > +PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc-crypto =
> > "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc-crypto} cortexa72
> > cortexa72-crc-crypto"
> > BASE_LIB:tune-cortexa72 = "lib64"
> > BASE_LIB:tune-cortexa72-crc = "lib64"
> > BASE_LIB:tune-cortexa72-crc-crypto = "lib64"
> >
> >
> >
> >
> >
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#160499):
https://lists.openembedded.org/g/openembedded-core/message/160499
Mute This Topic: https://lists.openembedded.org/mt/88369540/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
