On Sun, Jan 16, 2022 at 12:01:16PM +0000, Richard Purdie wrote: > [Please note: This e-mail is from an EXTERNAL e-mail address] > > On Sat, 2022-01-15 at 02:53 +0000, Anuj Mittal wrote: > > On Sat, 2022-01-15 at 10:37 +0800, Kevin Hao wrote: > > > From: Jagadeesh Krishnanjanappa <workjagade...@gmail.com> > > > > > > The cryptographic unit is optional for the Cortex-A72, but it was > > > included by default previously. This breaks building systems that > > > lack this functionality when using tune-cortexa72.inc. > > > > > > To correct this, add a crypto entry in the tune file. Since CRC is > > > optional for ARMv8.0, do the same thing while we're at it. > > > > > > For platforms that had been happily using tune-cortexa72.inc, a > > > slight > > > degradation of performance will occur using the default. To correct > > > this, simply add: > > > DEFAULTTUNE = "cortexa72-crc-crypto" > > > > > > > I am not very familiar with ARM tunes but it sounds like you are > > changing behaviour for people who might already be using these tunes > > with these two patches ... That might not be suitable for stable > > branches. > > > > Perhaps Ross, Jon or others can comment if this is something that > > should be merged in stable branches. > > You're right to be nervous of the change, I was with master. Having looked > into > the issue, it is a serious one and probably should be fixed. > > That said, I think there is perhaps a patch missing from this series, the one > which removes the cortexa72-crc tune.
I dropped that patch intentionally since it doesn't fix any real issue and may be not suitable for the stable branch. > I think this is fine even for a stable > series since the patch adding it is also in this series. The patches do make > more sense once looked at as a whole, Faire enough, I will send a v2 to include that patch. Thanks, Kevin > we just didn't get this quite right for > master at first. > > Cheers, > > Richard >
signature.asc
Description: PGP signature
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#160605): https://lists.openembedded.org/g/openembedded-core/message/160605 Mute This Topic: https://lists.openembedded.org/mt/88436676/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
