On 07.03.22 20:42, Ross Burton wrote:
If we expect users to extend this we should use =, as otherwise a recipe
that does += will replace the default value.
Signed-off-by: Ross Burton <[email protected]>
---
meta/classes/pip_install_wheel.bbclass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/classes/pip_install_wheel.bbclass
b/meta/classes/pip_install_wheel.bbclass
index c1680a24ed..febcc8e445 100644
--- a/meta/classes/pip_install_wheel.bbclass
+++ b/meta/classes/pip_install_wheel.bbclass
@@ -10,7 +10,7 @@ PIP_INSTALL_PACKAGE ?= "${@guess_pip_install_package_name(d)}"
PIP_INSTALL_DIST_PATH ?= "${@d.getVar('SETUPTOOLS_SETUP_PATH') or
d.getVar('B')}/dist"
PYPA_WHEEL ??= "${PIP_INSTALL_DIST_PATH}/${PIP_INSTALL_PACKAGE}-*-*.whl"
-PIP_INSTALL_ARGS ?= "\
+PIP_INSTALL_ARGS = "\
-vvvv \
--ignore-installed \
--no-cache \
Hmm all of the classes use ?= and I think for a reason - this isn't the
fault of the bbclass but of the recipe in the end, as += is known to
cause this depending on where the additions have been added (before the
inherit or after it) - I think the better way would be to use
PIP_INSTALL_ARGS:append in the actual recipe - guess the fallout would
be way less than the one I expect from this change.
The big question is if that should changeable by the user or not - I
personally think it should be
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#162864):
https://lists.openembedded.org/g/openembedded-core/message/162864
Mute This Topic: https://lists.openembedded.org/mt/89621292/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
