On Thu, 21 Jul 2022 at 11:13, Ross Burton <ross.bur...@arm.com> wrote:
>
>
> > On 20 Jul 2022, at 20:44, Daniel Gomez via lists.openembedded.org
> > <daniel=qtec....@lists.openembedded.org> wrote:
> > + ${@bb.utils.contains('DISTRO_FEATURES', 'x11', ' \
> > +
> > file://0007-Fix-X11-build-failure-use-DROPBEAR_PRIO_LOWDELAY.patch \
>
> This patch should be always applied, as it doesn’t cause any breakage when
> applied if not used. Patches which are conditional tend to cause breakage
> when they’re not always applied.
>
> > + file://0008-default_options-Enable-x11-forwarding.patch',
> > '', d)}”
>
> This should be a PACKAGECONFIG instead of a forced on/off based on
> DISTRO_FEATURES.
>
> Upstreaming a configure option to expose this as —enable-x-forwarding would
> be great, but for now you can easily sed this file as needed based on the
> value of PACKAGECONFIG.
Thanks Ross for the review. I'll send a v2 with the changes and look
into the upstream option.
>
> Ross
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#168383):
https://lists.openembedded.org/g/openembedded-core/message/168383
Mute This Topic: https://lists.openembedded.org/mt/92512561/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
