Hi Bero

Thanks for the patch!

On 10/27/22 20:58, Bernhard Rosenkränzer via lists.openembedded.org wrote:
Trying to build cmake-native on a host system where curl was built with cmake
(resulting in CURLConfig.cmake and friends, which do not use the same naming
schemes expected by cmake-native's build process, being installed to a system
wide cmake directory like /usr/lib64/cmake/CURL) results in undefined
references to all libcurl symbols.

The problem is that cmake-native sees and uses the system wide
/usr/lib64/cmake/CURL/CURLConfig.cmake, which defines CURL::libcurl and
CURL::curl as opposed to setting ${CURL_LIBRARIES} as expected by
cmake-native.

find_package(CURL) (cmake-native's CMakeLists.txt, line 478) succeeds, but
incorrectly uses the system wide CURLConfig.cmake, resulting
CMAKE_CURL_LIBRARIES to be set to an empty string (cmake-native's
CMakeLists.txt, line 484), causing the cmake-native build to miss -lcurl.

The simplest fix is to let cmake know the right value for
CURL_LIBRARIES. Making it -lcurl should always work with libcurl-native
in recipe-sysroot-native.

Signed-off-by: Bernhard Rosenkränzer <[email protected]>
---
  meta/recipes-devtools/cmake/cmake-native_3.22.3.bb | 1 +
  1 file changed, 1 insertion(+)


There's a problem with the way your patches are received on the Yocto Project mailing lists. I used to have it too.

If I apply your patch through "git am", the author of the commit will be:
Bernhard Rosenkränzer via lists.openembedded.org <[email protected]>
instead of
Bernhard Rosenkränzer <[email protected]>

That's because of the configuration of the Yocto Project mailing lists, if I understood correctly.

Because of this issue, the maintainer has to manually fix this field when accepting your patch. Worse, if he doesn't catch this, that's harder to fix afterwards.

You should be able to fix this by running:
git config --global sendemail.from "[email protected]"

This should add a "From" field to the sent patch which "git am" should be able to match with your name. At least this worked for me. See https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded#Sending_using_git-send-email

Could you try to send an update?

Thanks in advance
Michael.

--
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#172201): 
https://lists.openembedded.org/g/openembedded-core/message/172201
Mute This Topic: https://lists.openembedded.org/mt/94611412/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

  • [OE-core] [kirkstone... Bernhard Rosenkränzer via lists . openembedded . org
    • Re: [OE-core] [... Michael Opdenacker via lists.openembedded.org
      • [OE-core] [... Bernhard Rosenkränzer via lists . openembedded . org

Reply via email to