On 09/12/2022 10:55:16+0100, Ola x Nilsson wrote:
> 
> On Fri, Dec 09 2022, Khem Raj wrote:
> 
> > Thanks for the patches
> >
> > On 12/7/22 23:11, Ola x Nilsson wrote:
> >> Signed-off-by: Ola x Nilsson <ol...@axis.com>
> >> ---
> >>   meta/conf/distro/time64.conf | 23 +++++++++++++++++++++++
> >>   1 file changed, 23 insertions(+)
> >>   create mode 100644 meta/conf/distro/time64.conf
> >> 
> >> diff --git a/meta/conf/distro/time64.conf b/meta/conf/distro/time64.conf
> >> new file mode 100644
> >> index 0000000000..99eb06dc0f
> >> --- /dev/null
> >> +++ b/meta/conf/distro/time64.conf
> >> @@ -0,0 +1,23 @@
> >> +GLIBC_64BIT_TIME_FLAGS = "-D_TIME_BITS=64 -D_FILE_OFFSET_BITS=64"
> >> +
> >> +# TODO: Only for 32-bit architectures?
> >> +TARGET_CC_ARCH:append:arm = " ${GLIBC_64BIT_TIME_FLAGS}"
> >> +TARGET_CC_ARCH:append:armeb = " ${GLIBC_64BIT_TIME_FLAGS}"
> >> +TARGET_CC_ARCH:append:mips32el = " ${GLIBC_64BIT_TIME_FLAGS}"
> >
> > We should enable it across all 32bit systems
> > something like
> >
> > TARGET_CC_ARCH += "${@'-D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64' if 
> > d.getVar('SITEINFO_BITS') == '32' else ''}"
> >
> > would do it.
> 
> I was looking for a way to identify 32-bit platforms but did not find
> SITEINFO_BITS.  I'll look into using that instead.
> 

I don't think it is correct to assume all the 32bit platforms are
affected. riscv32 is not affected for example nor would be any newer
32bit architecture.


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#174450): 
https://lists.openembedded.org/g/openembedded-core/message/174450
Mute This Topic: https://lists.openembedded.org/mt/95533494/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to