On Fri, 2023-01-06 at 14:32 +0100, Alexander Kanavin wrote: > Now I see what's going on. The fs-uuid class contains two functions: > get_rootfs_uuid, and replace_rootfs_uuid. The former is not used > anywhere, but the latter is. Can you introduce get_rootfs_uuid() into > something in oe-core, perhaps it could enhance existing code somewhere > (maybe complement replace_rootfs_uuid usage?), or a test could be made > better? > > Otherwise, it's still not tested, and will regress without notice.
I still didn't quite understand this explanation since replace_rootfs_uuid() calls get_rootfs_uuid(). The issue is that UUID_PLACEHOLDER isn't used anywhere in core: UUID_PLACEHOLDER = '<<uuid-of-rootfs>>' which means that get_rootfs_uuid() is never called. There are some hints about how this should be used here: https://git.yoctoproject.org/poky/commit/meta/?id=6d7bcd4df5722f3ccebbbf73361838cb0a5dc0ee The fix is therefore probably ok but a test of UUID_PLACEHOLDER is missing. Looking at the class code, these two functions should be moved to lib/oe/ as well, we don't need a bbclass for this. Cheers, Richard
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#175971): https://lists.openembedded.org/g/openembedded-core/message/175971 Mute This Topic: https://lists.openembedded.org/mt/95823853/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
