I'm seeing following QA issue after this change:

ERROR: nativesdk-qemu-8.0.0-r0 do_package_qa: QA Issue:
nativesdk-qemu-user-mips rdepends on nativesdk-bash, but it isn't a build
dependency, missing nativesdk-bash in DEPENDS or PACKAGECONFIG? [build-deps]
ERROR: nativesdk-qemu-8.0.0-r0 do_package_qa: Fatal QA errors were found,
failing task.

On Fri, 9 Jun 2023 at 08:22, Martin Jansa <martin.ja...@gmail.com> wrote:

> On Fri, Jun 9, 2023 at 5:04 AM Yu, Mingli <mingli...@eng.windriver.com>
> wrote:
>
>> +    if userpackages:
>> +        d.setVar('RDEPENDS:' + d.getVar('PN') + '-user-all', '
>> '.join(userpackages))
>> +    mipspackage = d.getVar('PN') + "-user-mips"
>> +    if mipspackage in ' '.join(userpackages):
>> +        d.appendVar('RDEPENDS:' + mipspackage, ' ' +
>> d.getVar("MLPREFIX") + 'bash')
>>
>
> This is just a style question, you don't need to update.
>
> Is it worth making this conditional on ${PN}-user-mips existence? I would
> just use
>
> RDEPENDS:${PN}-user-mips = "bash"
>
> outside this function and I don't think you would even need to explicitly
> use ${MLPREFIX}. Nothing will break when ${PN}-user-mips doesn't exist
> (e.g. when splitting is disabled) and it's a bit easier to read than
> corresponding 3 lines in python.
>
> 
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#182672): 
https://lists.openembedded.org/g/openembedded-core/message/182672
Mute This Topic: https://lists.openembedded.org/mt/99421260/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to