The comment is indeed obsolete, so the comment can be removed. But not
the actual line, because 9.0 is less than 9.0.1527.

"Upstream version unknown" also means that we for whatever reason set
PV to something later than latest upstream.
The reason in this case being vim's never ending stream of CVE fixes,
and tagging each commit in git.

Please check your changes with 'devtool check-upgrade-status vim' as well.

Alex

On Fri, 18 Aug 2023 at 15:47, Etienne Cordonnier via
lists.openembedded.org <ecordonnier=snap....@lists.openembedded.org>
wrote:
>
> From: Etienne Cordonnier <ecordonn...@snap.com>
>
> vim 8.3 has been out for a long time, so this can be reverted.
>
> Test results:
> $ devtool latest-version vim
> ...
> ...
> INFO: Current version: 9.0.1527
> INFO: Latest version: 9.0
>
> This reverts commit 11d8ee09b1bdec4824203dc0169093b2ae9d101a.
>
> Signed-off-by: Etienne Cordonnier <ecordonn...@snap.com>
> ---
>  meta/recipes-support/vim/vim.inc | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/meta/recipes-support/vim/vim.inc 
> b/meta/recipes-support/vim/vim.inc
> index 33ae0d8079..e8c5074361 100644
> --- a/meta/recipes-support/vim/vim.inc
> +++ b/meta/recipes-support/vim/vim.inc
> @@ -22,9 +22,6 @@ SRC_URI = 
> "git://github.com/vim/vim.git;branch=master;protocol=https \
>  PV .= ".1592"
>  SRCREV = "29b4c513b11deb37f0e0538df53d195f602fa42c"
>
> -# Remove when 8.3 is out
> -UPSTREAM_VERSION_UNKNOWN = "1"
> -
>  # Do not consider .z in x.y.z, as that is updated with every commit
>  UPSTREAM_CHECK_GITTAGREGEX = "(?P<pver>\d+\.\d+)\.0"
>
> --
> 2.36.1.vfs.0.0
>
>
> 
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#186377): 
https://lists.openembedded.org/g/openembedded-core/message/186377
Mute This Topic: https://lists.openembedded.org/mt/100820547/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to