On Fri, 2023-09-08 at 09:29 +0300, Mikko Rapeli wrote: > Hi, > > On Thu, Sep 07, 2023 at 11:11:20PM +0100, Richard Purdie wrote: > > Originally these were shell functions but they have long since been > > processed by > > bb.build.exec_func(). Since we no longer need shell syntax, we can drop the > > ';' > > delimiters and just use a space separated string. > > > > This cleans up the variable and quietly removes any stray ';' that do > > happen to > > still make it in. > > I'm afraid many layers and recipes may be breaking with this because of > missing > space in appends, e.g. > > IMAGE_PREPROCESS_COMMAND:append = "foo;" > > used to work, and now will fail. Fix is to use > > IMAGE_PREPROCESS_COMMAND:append = " foo" > > but I wonder if we could help detect these?
At runtime I'd at least expect there would be failure from an invalid function name? Earlier detection is going to be trickier though. > And I have dislike for :append when a plain += would work > and would add the needed space chars and still allow overriding > the variable elsewhere when it is needed. But maybe that's just me. We both do, I'd love to go through our metadata and reduce the number of append usages. At least for the initial patch, I tried to avoid that in this case. Cheers, Richard
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#187409): https://lists.openembedded.org/g/openembedded-core/message/187409 Mute This Topic: https://lists.openembedded.org/mt/101225689/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
