On Sat, Oct 28, 2023 at 9:51 AM Richard Purdie <richard.pur...@linuxfoundation.org> wrote: > > On Sat, 2023-10-28 at 08:35 -0400, Bruce Ashfield wrote: > > On Fri, Oct 27, 2023 at 8:07 PM BELHADJ SALEM Talel <bhsta...@gmail.com> > > wrote: > > > > > > The module class provides what is needed to compile a Linux Kernel module > > > but since the Makefile is always the same for simple modules that have > > > their sources in one directory level, I thought of creating new class > > > wrapper > > > to automatically prepare the Makefile. > > > Also, using variable flag feature, a recipe can provide multiple modules > > > and can be handled the same way as PACKAGECONFIG is used to > > > enabled/disable > > > features. > > > > I find this method of preparing a kernel module much harder to follow > > (and debug). > > > > So Richard is ok with the class, I have no objections, it may serve a class > > of > > developers, but it isn't something I'd support as a first option. > > > > But please, create a separate example for it, not modifying hello-world, we > > want > > that simple and explicit example to persist. > > Richard isn't convinced. > > In most cases a kernel module from a source repository would have some > form of makefile included with it. yes, if you're creating one from > scratch, this is helpful but in general you do create a makefile at > that point and are unlikely to want to keep auto-generating one. > > As such I'm not convinced this class matches the siutation most people > wanting to build software would be in.
Everyone probably knows that I'm not in favour of generating pretty much anything that can be clearer and more explicit. :) I re-read my first reply, and it wasn't clear. It should have read "if Richard is ok", ... those joining words are important. What I meant to convey is that I wouldn't block something like this, if you were ok with it! Bruce > > Cheers, > > Richard -- - Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end - "Use the force Harry" - Gandalf, Star Trek II
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#189767): https://lists.openembedded.org/g/openembedded-core/message/189767 Mute This Topic: https://lists.openembedded.org/mt/102233042/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
