-----Original Message-----
From: openembedded-core@lists.openembedded.org 
<openembedded-core@lists.openembedded.org> On Behalf Of Xu, Lizhi via 
lists.openembedded.org
Sent: Tuesday, November 28, 2023 9:45
To: Marko, Peter (ADV D EU SK BFS1) <peter.ma...@siemens.com>
Cc: alex.kier...@gmail.com; openembedded-core@lists.openembedded.org
Subject: Re: [PATCH V2] [OE-core] tzdata: Reduced time zone configuration

> On Tue, 28 Nov 2023 08:13:57 +0000, Marko, Peter wrote:
> > > > > > tzdata.bb by default pulls in all possible timezone data 
> > > > > > packages which increases size of the final root filesystem 
> > > > > > considerably.
> > > > > > The customer would like to have extra timezones configurable 
> > > > > > so that only tzdata-core is chosen by default and rest of the zones 
> > > > > > are optional.
> > > > > > This change would make the fs size a lot smaller.
> > > > > >
> > > > > > Comparison of customized package volume before and after:
> > > > > > When TZ_PACKAGES contains all tzdata packets, the image size of 
> > > > > > tzdata is 7.4MB.
> > > > > > The difference in mirror size between the two is 7MB.
> > > > > >
> > > > > > When TZ_PACKAGES only retains one tzdata-core, the image size 
> > > > > > generated by tzdata is 320KB.
> > > > > >
> > > > > > Signed-off-by: Lizhi Xu <lizhi...@windriver.com>
> > > > >
> > > > > I get what you're trying to do, but this looks horrid. How about 
> > > > > splitting into multiple packages based on top level directory 
> > > > > (plus the few which sit in the top level directory) using a new 
> > > > > PACKAGESPLITFUNCS so you don't have to hardcode the list of packages?
> > > > >
> > > >
> > > > Foolishly, I didn't actually look at what was in the tzdata recipe 
> > > > first and it already splits things... I'm lost, can't you just 
> > > > remove things from TZ_PACKAGES to get what you're after?
> > > To achieve a final reduction in the size of the tzdata package, simply 
> > > configuring TZ_PACKAGES is not enough. It is also necessary to delete the 
> > > corresponding zoneinfo when generating the final package, this requires 
> > > performing the corresponding deletion operation in the do_install() task 
> > > simultaneously, which is too complex for users.
> > >
> > > Therefore, this patch is provided to simplify the step of reducing 
> > > package size.
> > > After applying this patch, users only need to modify the OP_TZ in tzd.inc 
> > > to determine which time zones are needed in the final generated package, 
> > > in order to facilitate customization of the final size of the tzdata 
> > > package.
> > >
> > > Thanks,
> > > Lizhi
> > 
> > This is the wrong way how to achieve smaller rootfs.
> > If you grep oe-core and meta-oe for tzdata, you'll see that you break 
> > things (e.g. glib-2.0 ptest depends on specific tzdata you're trying to 
> > remove).
> If the default value of "OP_TZ" is adjusted to the following value, the 
> problem you described will not occur:
> OP_TZ = "tzdata-misc tzdata-posix tzdata-right tzdata-africa \
>     tzdata-americas tzdata-antarctica tzdata-arctic tzdata-asia \
>     tzdata-atlantic tzdata-australia tzdata-europe tzdata-pacific \  "
> > 
> > Yocto has concept of packages and tzdata is good example how to use them.
> > Just install packages you need instead of generic tzdata package which 
> > pulls all.
> > If you need the empty main tzdata package because of its postinst, then 
> > just reduce the list what is pulled here:
> > RDEPENDS:${PN} = "${TZ_PACKAGES}"
> I didn't understand what you said. 
> If we don't adjust tzdata.bb and instead adjust all packages that depend on 
> tzdata at runtime, the customer may lose patience.
>
> Lizhi

I meant that your patch can be probably reduced to following:
- RDEPENDS:${PN} = "${TZ_PACKAGES}"
+ MAIN_TZ_PACKAGES ?= "${TZ_PACKAGES}"
+ RDEPENDS:${PN} = "${MAIN_TZ_PACKAGES}"
And they you can just do following in your distro:
MAIN_TZ_PACKAGES:pn-tzdata = "tzdata-americas tzdata-europe"

Peter
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#191348): 
https://lists.openembedded.org/g/openembedded-core/message/191348
Mute This Topic: https://lists.openembedded.org/mt/102777104/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to