-----Original Message----- From: Richard Purdie <richard.pur...@linuxfoundation.org> Sent: Wednesday, December 13, 2023 22:58 To: Marko, Peter (ADV D EU SK BFS1) <peter.ma...@siemens.com>; openembedded-core@lists.openembedded.org; Kanavin, Alexander (EXT) (Linutronix GmbH) <a...@linutronix.de> Subject: Re: [OE-core][PATCH] dtc: pass version as parameter instead of querying git
> On Wed, 2023-12-13 at 21:53 +0000, Marko, Peter wrote: > > > > I actually think that building from shallow clones is very non-standard > > scenario. > > Usual builds are either from full clones or from release tarballs. > > And meson nicely handles these two scenarios. > > Shallow tarball is an incomplete thing which has storage benefits but also > > misses things that buildsystems are relying on. > > And I don't think I can win a discussion with meson maintainers about this. > > The vcs functions are standard and have good fallbacks (e.g. to hash) > > I could maybe convince them to add option to disable fall back to git hash, > > but that would be a long-runner. > > They might be more receptive to adding an argument to allow the value to be > forced though, particularly if you can explain scenarios where this is the > only option and the code get it wrong? > > I do think we need to raise these issues with the upstreams and only carry > patches if we can't convince them of these challenges. > > > Maybe I could add an option to bitbake git fetcher to remove .git folder if > > needed? > > I'm not sure we want to encourage it. That is actually more maintainable even > in the recipe though. > > Cheers, > > Richard I reworked this completely, sent it to upstream and submitted as new patch to oe-core. Let's see what is the reaction. Peter
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#192568): https://lists.openembedded.org/g/openembedded-core/message/192568 Mute This Topic: https://lists.openembedded.org/mt/103158226/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
