On Sat, Dec 30, 2023 at 11:08 AM Richard Purdie <richard.pur...@linuxfoundation.org> wrote: > > On Fri, 2023-12-29 at 11:44 +0000, Alex Kiernan wrote: > > This is the 1.74.1 rust series rebased to include a revert of > > https://github.com/rust-lang/cc-rs/commit/c4f414f449bb7cffba3bc923f277704d1d08a8ec > > which I'm pretty sure is what's causing our filename churn. I've checked > > 1.72.0 and 1.74.1 for the absvdi2.o intrinsic (one of many intrinsics > > which had the issue) and in both cases we're not generating the dirname > > based prefix - hopefully that means that the interim commits are fine > > too, if not we can do the step back through the commits to find the next > > issue. > > > > Changes in v4: > > - Mark hello-rs as EXCLUDE_FROM_WORLD as it's not reproducible > > > > Changes in v3: > > - Add hello-rs as a replacement for the tests which used zvariant > > > > Changes in v2: > > - Skip zvariant based test rather than deleting it. > > > > Alex Kiernan (10): > > devtool: selftest: Fix test_devtool_modify_git_crates_subpath > > inequality > > devtool: selftest: Fix test_devtool_modify_git_crates_subpath bbappend > > check > > meta-selftest: hello-rs: Simple rust test recipe > > devtool: selftest: Swap to hello-rs for crates testing > > zvariant: Drop recipe > > rust: Upgrade 1.71.1 -> 1.72.0 > > rust: Upgrade 1.72.0 -> 1.72.1 > > rust: Upgrade 1.72.1 -> 1.73.0 > > rust: Upgrade 1.73.0 -> 1.74.0 > > rust: Upgrade 1.74.0 -> 1.74.1 > > Thanks for working through this, I've gone ahead and merged it :) > > I am a little worried that: > > * the test recipe isn't reproducible
This one concerns me... upstream is clearly trying to get reproducibility yet we're seeing issues. I worry that we're doing something which means they're not seeing it. > * we still have the tests disabled I think we need to find a way to engage with upstream on this - as far as I can tell they simply don't run the tests on release code, only on nightlies, so we're really going off-piste here. > * the next version looks problematic Hopefully I've found/fixed the issues - it looks like it's bugs from poor assumptions which don't hold true in our world and at least one FIXME in the upstream code :| Just tidying the patches and will send it shortly. > > but I think we're at the point it makes sense to move to the newer > version. > Thanks! -- Alex Kiernan
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#193072): https://lists.openembedded.org/g/openembedded-core/message/193072 Mute This Topic: https://lists.openembedded.org/mt/103415633/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-