> -----Original Message-----
> From: Richard Purdie <richard.pur...@linuxfoundation.org>
> Sent: den 4 mars 2024 17:17
> To: Peter Kjellerstedt <peter.kjellerst...@axis.com>;
> openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH 1/2] kernel-module-dirs.bbclass: Add class
>
> On Mon, 2024-03-04 at 16:57 +0100, Peter Kjellerstedt wrote:
> > Split out the two variables modulesloaddir and modprobedir from
> > kernel-module-split.bbclass as they can be useful to other recipes than
> > kernel module recipes.
> >
> > Signed-off-by: Peter Kjellerstedt <peter.kjellerst...@axis.com>
> > ---
> > meta/classes-recipe/kernel-module-dirs.bbclass | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> > create mode 100644 meta/classes-recipe/kernel-module-dirs.bbclass
> >
> > diff --git a/meta/classes-recipe/kernel-module-dirs.bbclass
> > b/meta/classes-recipe/kernel-module-dirs.bbclass
> > new file mode 100644
> > index 0000000000..eecc36ab52
> > --- /dev/null
> > +++ b/meta/classes-recipe/kernel-module-dirs.bbclass
> > @@ -0,0 +1,8 @@
> > +#
> > +# Copyright OpenEmbedded Contributors
> > +#
> > +# SPDX-License-Identifier: MIT
> > +#
> > +
> > +modulesloaddir ??= "${@bb.utils.contains('DISTRO_FEATURES', 'systemd',
> > '${nonarch_libdir}', '${sysconfdir}', d)}/modules-load.d"
> > +modprobedir ??= "${@bb.utils.contains('DISTRO_FEATURES', 'systemd',
> > '${nonarch_base_libdir}', '${sysconfdir}', d)}/modprobe.d"
>
> Absolutely not. We are not having yet more kernel classes just for two
> variables.
Ok. I considered adding them to bitbake.conf where all other similar *dir
variables are defined, but I opted for a bbclass since I expect it to only
be relatively few recipes that need either of them (we currently have ~10
non-module recipes that could use them).
>
> There is probably a better way moving some definitions to a new conf
> file for the kernel in general.
I am not sure what to make of this. What I wanted to achieve was to be
able to make the two path variables available to non-module recipes. I am
not sure how that matches what you meant with "a new conf file for the
kernel". Did you actually mean a .conf file where the variables would be
added to the global state, or did you mean a .bbclass/.inc file similar to
the one I proposed, but with a more generic name so that it can take other
variables than just the two path variables above?
>
> Cheers,
>
> Richard
//Peter
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#196614):
https://lists.openembedded.org/g/openembedded-core/message/196614
Mute This Topic: https://lists.openembedded.org/mt/104724883/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
